zhangmeng916 opened a new pull request #992: URL: https://github.com/apache/helix/pull/992
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: (#990 ) ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Currently there is a bug in the version comparison logic for compatibility check stage. It worked with all version starting with number "0". However, the comparison check would fail after we release version 1.0.0. The impact is the pipeline that includes compatibility check stage would fail due to the incompatibility error. This PR fixed the issue by modifying the logic in the loop. If the participant version's digit number is larger than the minimum version digit number, we terminate the loop. ### Tests - [X] The following tests are written for this issue: TestCompatibilityCheckStage. - [X] The following is the result of the "mvn test" command on the appropriate module: (Copy & paste the result of "mvn test") ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
