zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419630944
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
##########
@@ -116,6 +116,8 @@ static boolean versionNoLessThan(String version1, String
version2) {
if (versionNum1 < versionNum2) {
return false;
+ } else if (versionNum1 > versionNum2) {
Review comment:
This is not to ignore the check. This is a digit by digit comparison.
See above code, the version is already split. So we are comparing "1" to "0",
which breaks the loop. If it's "0" to "0", we will continue to compare next
digit. It should be complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
