zhangmeng916 commented on a change in pull request #992:
URL: https://github.com/apache/helix/pull/992#discussion_r419632821
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
##########
@@ -116,6 +116,8 @@ static boolean versionNoLessThan(String version1, String
version2) {
if (versionNum1 < versionNum2) {
return false;
+ } else if (versionNum1 > versionNum2) {
Review comment:
Previous error is just that it didn't break even the digit is larger the
minimum version. I guess it didn't consider we might bump to 1.0.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
