alirezazamani opened a new pull request #994: URL: https://github.com/apache/helix/pull/994
### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #984 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In this commit, several parts of the code have been removed in order to avoid making scheduling decision based on PreviousAssignment. Instead we are relying on the CurrentState. In order to facilitate this, the tasks that reaches the terminal state (Error, Time_out, Aborted and completed) will be dropped and rescheduled in later pipeline if needed (If they need to be rescheduled). This helps us to reduce the number of existing current states for each task. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestWorkflowTermination.testWorkflowJobFail:251->verifyWorkflowCleanup:257 expected:<true> but was:<false> [ERROR] TestWorkflowTimeout.testWorkflowTimeoutWhenWorkflowCompleted:116 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1144, Failures: 2, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:21 h [INFO] Finished at: 2020-05-01T15:25:20-07:00 [INFO] ------------------------------------------------------------------------ The failed tests has passed when I ran it individually. ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
