alirezazamani commented on a change in pull request #994:
URL: https://github.com/apache/helix/pull/994#discussion_r428327174
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -242,16 +230,16 @@ public void updatePreviousAssignedTasksStatus(
}
break;
case COMPLETED: {
- // The task has completed on this partition. Mark as such in the
context object.
- donePartitions.add(pId);
+ // The task has completed on this partition. Drop it from the
instance and add it to assignedPartitions in
+ // order to avoid scheduling it again in this pipeline.
Review comment:
Exactly. Since we do not get DROPPED state in current state, we will not
mark the the task as DROPPED in job context. If the task is completed and we
send COMPLETE to DROPPED message, then the participant will DROP the
currentstate (meaning it will be removed from currentState) and this function
will not see the task on the instance again because we are based on
CurrentState now. Hence, we will not mark the task DROPPED in jobContext.
Basically since in this function context follows the currentState, then DROPPED
context will not be possible. Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
