alirezazamani commented on a change in pull request #994:
URL: https://github.com/apache/helix/pull/994#discussion_r428928371
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
##########
@@ -238,21 +238,20 @@ private ResourceAssignment computeResourceMapping(String
jobResource,
// These dropping transitions will be prioritized above all task state
transition assignments
Map<String, Set<Integer>> tasksToDrop = new HashMap<>();
- Map<String, SortedSet<Integer>> prevInstanceToTaskAssignments =
- getPrevInstanceToTaskAssignments(liveInstances,
prevTaskToInstanceStateAssignment,
- allPartitions, currStateOutput, jobResource, tasksToDrop);
+ Map<String, SortedSet<Integer>> currentInstanceToTaskAssignments =
+ getCurrentInstanceToTaskAssignments(liveInstances, currStateOutput,
jobResource, tasksToDrop);
- updateInstanceToTaskAssignmentsFromContext(jobCtx,
prevInstanceToTaskAssignments);
+ updateInstanceToTaskAssignmentsFromContext(jobCtx,
currentInstanceToTaskAssignments);
long currentTime = System.currentTimeMillis();
if (LOG.isDebugEnabled()) {
LOG.debug("All partitions: " + allPartitions + " taskAssignment: "
- + prevInstanceToTaskAssignments + " excludedInstances: " +
excludedInstances);
+ + currentInstanceToTaskAssignments + " excludedInstances: " +
excludedInstances);
}
// Release resource for tasks in terminal state
- updatePreviousAssignedTasksStatus(prevInstanceToTaskAssignments,
excludedInstances, jobResource,
+ updatePreviousAssignedTasksStatus(currentInstanceToTaskAssignments,
excludedInstances, jobResource,
Review comment:
I think it should be fine to keep it as it is. Because we are updating
the state of the tasks that has been assigned in previous pipelines based on
the currentstate of the tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
