narendly commented on a change in pull request #973:
URL: https://github.com/apache/helix/pull/973#discussion_r420434219



##########
File path: helix-core/src/main/java/org/apache/helix/model/LiveInstance.java
##########
@@ -190,6 +192,24 @@ public void setWebserviceUrl(String url) {
     
_record.setSimpleField(LiveInstanceProperty.ZKPROPERTYTRANSFERURL.toString(), 
url);
   }
 
+  /**
+   * Get the current task thread pool size of the instance
+   * @return the current task thread pool size
+   */
+  public int getCurrentTaskThreadPoolSize() {
+    return 
_record.getIntField(LiveInstanceProperty.CURRENT_TASK_THREAD_POOL_SIZE.name(),
+        CURRENT_TASK_THREAD_POOL_SIZE_NOT_SET);

Review comment:
       Please try to understand the proposed design thoroughly.
   
   For example, what does it mean for an instance to have a task thread pool of 
size -1? (it is meaningless, we shouldn't create a task pool with size -1).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to