narendly commented on a change in pull request #973:
URL: https://github.com/apache/helix/pull/973#discussion_r420466018
##########
File path:
helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java
##########
@@ -41,23 +47,15 @@
private final HelixManager _manager;
private final Map<String, TaskFactory> _taskFactoryRegistry;
- private final ScheduledExecutorService _taskExecutor;
+ private ScheduledExecutorService _taskExecutor;
Review comment:
Update:
Neal and I had an offline discussion. To simplify the design, we will create
a temporary ZK connection to read the task pool size configs and close right
away. This would greatly simplify the code and this won't be that much of a
burden since the connection is closed right away.
This is to populate the current task size pool at the time of LiveInstance
(ephemeral node) initialization.
@NealSun96 Please remember to put a TODO here to potentially revisit the
logic - ideally, we shouldn't have to create multiple ZK client connections
when there already is a manager there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
