NealSun96 commented on a change in pull request #973:
URL: https://github.com/apache/helix/pull/973#discussion_r420963940
##########
File path: helix-core/src/main/java/org/apache/helix/model/LiveInstance.java
##########
@@ -48,6 +49,7 @@
TASK_EXEC_THREAD
}
+ public static final int CURRENT_TASK_THREAD_POOL_SIZE_NOT_SET = -1;
Review comment:
If there is ever a case where CURRENT_TASK_THREAD_POOL_SIZE is not set,
I don't think the controller should proceed. But @narendly raised a good point
offline - it could be an old participant that doesn't have this field. I'm
using the default 40 instead as there's no better options in that case. Thank
you all for the input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
