alirezazamani commented on a change in pull request #994:
URL: https://github.com/apache/helix/pull/994#discussion_r428930744
##########
File path:
helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -121,17 +120,6 @@ public void updatePreviousAssignedTasksStatus(
instance, pId);
continue;
}
Review comment:
This shouldn't be an issue because this check is specifically added
before to bypass the scenario where we have two current states which non of the
markPartitionCompleted/markPartitionError will not be hit because it is either
Running or Dropped. Good question though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
