narendly commented on a change in pull request #1045:
URL: https://github.com/apache/helix/pull/1045#discussion_r433000087
##########
File path: helix-common/helix-common-1.0.1-SNAPSHOT.ivy
##########
@@ -43,9 +43,7 @@ under the License.
<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.14" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)">
<artifact name="slf4j-log4j12" ext="jar"/>
</dependency>
- <dependency org="org.yaml" name="snakeyaml" rev="1.12"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
- <dependency org="org.codehaus.jackson" name="jackson-core-asl"
rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="org.codehaus.jackson"
name="jackson-mapper-asl" rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="commons-cli" name="commons-cli" rev="1.2"
force="true" conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="metrics-common"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="zookeeper-api"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
Review comment:
I'm not sure if this is the correct version we should use in .ivy file.
Could you double check that our version bump up script replaces these versions
to the correct one at build time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
