pkuwm commented on a change in pull request #1045:
URL: https://github.com/apache/helix/pull/1045#discussion_r438482182
##########
File path: metrics-common/metrics-common-0.9.2-SNAPSHOT.ivy
##########
@@ -43,5 +43,6 @@ under the License.
<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.14" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)">
<artifact name="slf4j-log4j12" ext="jar"/>
</dependency>
+ <dependency org="io.dropwizard.metrics" name="metrics-core" rev="3.2.3"
conf="compile->compile(*),master(*);runtime->runtime(*)/>
Review comment:
It is to make sure jars built with ivy have the same dependencies with
jars built with maven pom.
##########
File path: helix-core/pom.xml
##########
@@ -128,30 +128,10 @@ under the License.
<artifactId>commons-math3</artifactId>
<version>3.6.1</version>
</dependency>
- <dependency>
- <groupId>commons-codec</groupId>
- <artifactId>commons-codec</artifactId>
- <version>1.6</version>
- </dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <version>15.0</version>
- </dependency>
<dependency>
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
- <version>1.12</version>
- </dependency>
- <dependency>
- <groupId>io.dropwizard.metrics</groupId>
- <artifactId>metrics-core</artifactId>
- <version>3.2.3</version>
- </dependency>
- <dependency>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpclient</artifactId>
- <version>4.5.8</version>
+ <version>1.17</version>
Review comment:
Same. It is because "open source libraries aren't always backward
compatible and could cause unwarranted code behavior change.". We have
different dependency versions for Jackson-core-asl. In run time, this version
difference may cause conflict and exceptions like NoSuchClassException. I
actually would like to upgrade it to make sure only one version is used in our
project to avoid conflicts.
##########
File path: helix-admin-webapp/pom.xml
##########
@@ -79,12 +79,12 @@ under the License.
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
- <version>1.8.5</version>
Review comment:
It is because "open source libraries aren't always backward compatible
and could cause unwarranted code behavior change.". We have different
dependency versions for Jackson-core-asl. In run time, this version difference
may cause conflict and exceptions like `NoSuchClassException`. I actually would
like to upgrade it to make sure only one version is used in our project to
avoid conflicts.
##########
File path: zookeeper-api/zookeeper-api-1.0.1-SNAPSHOT.ivy
##########
@@ -43,9 +43,10 @@ under the License.
<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.14" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)">
<artifact name="slf4j-log4j12" ext="jar"/>
</dependency>
- <dependency org="org.codehaus.jackson" name="jackson-core-asl"
rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="org.codehaus.jackson"
name="jackson-mapper-asl" rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="commons-cli" name="commons-cli" rev="1.2"
force="true" conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="org.apache.httpcomponents" name="httpclient"
rev="4.5.8" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="metrics-common"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="metadata-store-directory-common"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.zookeeper" name="zookeeper" rev="3.4.13"
force="true" conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.codehaus.jackson" name="jackson-mapper-asl"
rev="1.9.13" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="commons-codec" name="commons-codec" rev="1.14"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
Review comment:
It is to make sure jars built with ivy have the same dependencies with
jars built with maven pom.
##########
File path: helix-common/helix-common-1.0.1-SNAPSHOT.ivy
##########
@@ -43,9 +43,7 @@ under the License.
<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.14" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)">
<artifact name="slf4j-log4j12" ext="jar"/>
</dependency>
- <dependency org="org.yaml" name="snakeyaml" rev="1.12"
conf="compile->compile(default);runtime->runtime(default);default->default"/>
- <dependency org="org.codehaus.jackson" name="jackson-core-asl"
rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="org.codehaus.jackson"
name="jackson-mapper-asl" rev="1.8.5" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
- <dependency org="commons-cli" name="commons-cli" rev="1.2"
force="true" conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="metrics-common"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
+ <dependency org="org.apache.helix" name="zookeeper-api"
rev="1.0.1-SNAPSHOT" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)"/>
Review comment:
It is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
