narendly commented on a change in pull request #1045:
URL: https://github.com/apache/helix/pull/1045#discussion_r433000497
##########
File path: metrics-common/metrics-common-0.9.2-SNAPSHOT.ivy
##########
@@ -43,5 +43,6 @@ under the License.
<dependency org="org.slf4j" name="slf4j-log4j12" rev="1.7.14" force="true"
conf="compile->compile(*),master(*);runtime->runtime(*)">
<artifact name="slf4j-log4j12" ext="jar"/>
</dependency>
+ <dependency org="io.dropwizard.metrics" name="metrics-core" rev="3.2.3"
conf="compile->compile(*),master(*);runtime->runtime(*)/>
Review comment:
I am not sure if this library would be needed in the ivy file. We may
not need to include this because we don't need this available other than build
time to create a JAR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
