pkuwm commented on pull request #1053: URL: https://github.com/apache/helix/pull/1053#issuecomment-637938685
This PR is ready to be merged, approved by @narendly ``` Test testDropInstance doesn't assert expected HelixException, so when a live instance is not created, the test still passes. The reason is the test uses a sharedZkClient to create a live instance but fails. This PR addresses this issue by creating a dedicated zkclient in ZkBaseDataAccessor to create a live instance. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
