lei-xia commented on a change in pull request #1053:
URL: https://github.com/apache/helix/pull/1053#discussion_r434663662
##########
File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
##########
@@ -356,51 +360,65 @@ public void testDropInstance() throws Exception {
"MasterSlave", true); // do rebalance
// add fake liveInstance
- ZKHelixDataAccessor accessor =
- new ZKHelixDataAccessor(clusterName, new
ZkBaseDataAccessor<ZNRecord>(ZK_ADDR));
Review comment:
Does this mean if user constructs a ZKHelixDataAccessor with a ZK-ADDR,
they can create an ephemeral node before, but not anymore after they bump to
1.0.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
