pkuwm commented on a change in pull request #1053:
URL: https://github.com/apache/helix/pull/1053#discussion_r434794029
##########
File path: helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
##########
@@ -356,51 +360,65 @@ public void testDropInstance() throws Exception {
"MasterSlave", true); // do rebalance
// add fake liveInstance
- ZKHelixDataAccessor accessor =
- new ZKHelixDataAccessor(clusterName, new
ZkBaseDataAccessor<ZNRecord>(ZK_ADDR));
Review comment:
@lei-xia No, it doesn't. Before 1.0.0, a ZKHelixDataAccessor with a
ZK-ADDR is not able create an ephemeral node. It is also by default using a
shared zkclient internally. The only difference is the type of exceptions:
before 1.0.0, `HelixException` is thrown from sharedZkClient, while in 1.0.0,
`UnsupportedOperationException` is thrown.
The root cause for this test is, even though a live instance(ephemeral node)
is not created by the ZKHelixDataAccessor with a ZK-ADDR, the test still
passes, because the test doesn't catch or verify the correct result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
