jiajunwang commented on a change in pull request #1109:
URL: https://github.com/apache/helix/pull/1109#discussion_r443960242



##########
File path: 
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -103,6 +109,13 @@
   // ZkEventThread. Otherwise the retry request might block the normal event 
processing.
   protected final ZkAsyncRetryThread _asyncCallRetryThread;
 
+  static {

Review comment:
       That is a new way of testing for me. But I saw you modified packetLen in 
the ClientCnxn, which is initialized like this,
   `public static final int packetLen = Integer.getInteger("jute.maxbuffer",
               4096 * 1024);`
   
   Does it mean even we do
   `private static final int NUM_CHILDREN_LIMIT = 100 * 1000;`
   the test will still work?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to