lei-xia commented on a change in pull request #1129:
URL: https://github.com/apache/helix/pull/1129#discussion_r455883211
##########
File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
##########
@@ -1009,4 +1010,19 @@ public ConfigAccessor build() {
_zkAddress), false);
}
}
+
+ /**
+ * Validate if the topology related settings (Domain or ZoneId) in the given
instanceConfig
+ * are valid and align with current clusterConfig.
+ * This function should be called when instance added to cluster or caller
updates instanceConfig.
+ *
+ * @throws IllegalArgumentException
+ */
+ public static boolean validateTopologySettingInInstanceConfig(ClusterConfig
clusterConfig,
Review comment:
Seems this method is not used by ConfigAccessor itself? My suggestion
is put this method into InstanceConfig (or ClusterConfig) and it does not have
to be static (it can be called like
myInstanceConfig.validateTopologySetting(String clusterTopologyString).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
