jiajunwang commented on a change in pull request #1124:
URL: https://github.com/apache/helix/pull/1124#discussion_r456631442
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java
##########
@@ -236,6 +267,11 @@ private void updateCurrentStates(LiveInstance instance,
Collection<CurrentState>
}
}
+ private void setStaleMessage(CurrentStateOutput currentStateOutput, String
instanceName,
Review comment:
This is related to my other comment. In general, we shall not pass a
modifiable map ref directly. Especially if the passed ref will be used to
update. And given that you make a shallow copy instead of just pass the ref,
then we will need both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
