zhangmeng916 commented on a change in pull request #1124:
URL: https://github.com/apache/helix/pull/1124#discussion_r458998999
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java
##########
@@ -148,9 +152,20 @@ public boolean refresh(HelixDataAccessor accessor,
Map<String, LiveInstance> liv
LOG.info(
"END: InstanceMessagesCache.refresh(), {} of Messages read from
ZooKeeper. took {} ms. ",
newMessageKeys.size(), (System.currentTimeMillis() - startTime));
+
+ refreshStaleMessageCache();
return true;
}
+ public Map<String, Map<String, Message>> getStaleMessageCache() {
Review comment:
Tried to only use `getStaleMessageCache()` in this class. But it's
difficult to change the test to check this class directly. So keep the
function in two classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
