zhangmeng916 commented on a change in pull request #1124:
URL: https://github.com/apache/helix/pull/1124#discussion_r458314319
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java
##########
@@ -102,15 +114,22 @@ public void process(ClusterEvent event) throws Exception {
// update all pending messages to CurrentStateOutput.
private void updatePendingMessages(LiveInstance instance,
Collection<Message> pendingMessages,
- CurrentStateOutput currentStateOutput, Collection<Message>
pendingRelayMessages,
- Map<String, Resource> resourceMap) {
+ Collection<Message> pendingRelayMessages,
+ Map<String, Map<String, Message>> existingStaleMessages,
+ CurrentStateOutput currentStateOutput, Map<String, Resource>
resourceMap) {
String instanceName = instance.getInstanceName();
String instanceSessionId = instance.getEphemeralOwner();
// update all pending messages
for (Message message : pendingMessages) {
+ // ignore existing stale messages
+ if (existingStaleMessages.getOrDefault(instanceName,
Collections.emptyMap())
Review comment:
CurrentStateOutput currently does not have stale messages in it. It's
not necessary because every class has access to cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
