zhangmeng916 opened a new pull request #1157: URL: https://github.com/apache/helix/pull/1157
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: (#1156 ") ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: In the test testDuplicateMsg from TestRebalancePipeline, currently an invalid session id is used. Here's the detail: setCurrentState(clusterName, "localhost_0", resourceName, resourceName + "_0", "session_1", "SLAVE"); The wrong session id makes the following test and assertion meaningless. This PR uses the correct session id liveInstances.get(0).getEphemeralOwner() instead. Meanwhile, we found a NPE thrown out during the pipeline and cause the pipeline to stop, which is due to the missing of `setAsyncTasksThreadPool` action. This PR also fixed the issue. ### Tests - [ ] The following is the result of the "mvn test" command on the appropriate module: ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
