narendly commented on a change in pull request #1157:
URL: https://github.com/apache/helix/pull/1157#discussion_r457124770
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
##########
@@ -61,8 +62,9 @@ public void testDuplicateMsg() {
HelixManager manager = new DummyClusterManager(clusterName, accessor);
ClusterEvent event = new ClusterEvent(ClusterEventType.Unknown);
event.addAttribute(AttributeName.helixmanager.name(), manager);
- event.addAttribute(AttributeName.ControllerDataProvider.name(),
- new ResourceControllerDataProvider());
+ ResourceControllerDataProvider dataCache = new
ResourceControllerDataProvider();
+ dataCache.setAsyncTasksThreadPool(Executors.newSingleThreadExecutor());
Review comment:
I see. Although not directly related to this PR, do you think we should
consider handling this NPE? It seems like something we should handle more
gracefully (we probably won't have this issue in production, the urgency won't
be too high). I'm fine with creating an issue with a clear context/what to fix
so that someone could pick it up in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
