zhangmeng916 commented on a change in pull request #1157:
URL: https://github.com/apache/helix/pull/1157#discussion_r457525016
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
##########
@@ -61,8 +62,9 @@ public void testDuplicateMsg() {
HelixManager manager = new DummyClusterManager(clusterName, accessor);
ClusterEvent event = new ClusterEvent(ClusterEventType.Unknown);
event.addAttribute(AttributeName.helixmanager.name(), manager);
- event.addAttribute(AttributeName.ControllerDataProvider.name(),
- new ResourceControllerDataProvider());
+ ResourceControllerDataProvider dataCache = new
ResourceControllerDataProvider();
+ dataCache.setAsyncTasksThreadPool(Executors.newSingleThreadExecutor());
Review comment:
Our controller has properly set this field during construction:
cache.setAsyncTasksThreadPool(_asyncTasksThreadPool);
I'd think the code itself should be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
