NealSun96 commented on a change in pull request #1129:
URL: https://github.com/apache/helix/pull/1129#discussion_r458945466
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java
##########
@@ -204,8 +172,9 @@ private Node createClusterTree() {
InstanceConfig insConfig = _instanceConfigMap.get(instanceName);
try {
LinkedHashMap<String, String> instanceTopologyMap =
-
computeInstanceTopologyMap(_clusterConfig.isTopologyAwareEnabled(),
instanceName,
- insConfig, _clusterTopologyKeys);
+
computeInstanceTopologyMapHelper(_clusterConfig.isTopologyAwareEnabled(),
instanceName,
Review comment:
I see. Typically if a concrete function involves a null value, such as
this case, it usually isn't called directly by outside callers and is only
called by its wrapper. I'm not 100% certain with the convention here so I'll
leave it to you to decide. Thank you for explaining!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
