xyuanlu commented on a change in pull request #1129:
URL: https://github.com/apache/helix/pull/1129#discussion_r458423497
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java
##########
@@ -43,11 +43,11 @@
*/
public class Topology {
private static Logger logger = LoggerFactory.getLogger(Topology.class);
+
public enum Types {
- ROOT,
- ZONE,
- INSTANCE
+ ROOT, ZONE, INSTANCE
Review comment:
I think auto formatter changes this..
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java
##########
@@ -463,5 +464,53 @@ public void testValidateWeightForInstance()
// Must have the results saying they are all valid (true) because capacity
keys are set
// in ClusterConfig
node.iterator().forEachRemaining(child ->
Assert.assertTrue(child.getBooleanValue()));
+ System.out.println("End test :" + TestHelper.getTestMethodName());
+ }
+
+ @Test(dependsOnMethods = "testValidateWeightForInstance")
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
