lei-xia commented on a change in pull request #1129:
URL: https://github.com/apache/helix/pull/1129#discussion_r455895924
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PerInstanceAccessor.java
##########
@@ -287,6 +288,7 @@ public Response getInstanceConfig(@PathParam("clusterId")
String clusterId,
@Path("configs")
public Response updateInstanceConfig(@PathParam("clusterId") String
clusterId,
@PathParam("instanceName") String instanceName, @QueryParam("command")
String commandStr,
+ @DefaultValue("false") @QueryParam("doSanityCheck") boolean
doSanityCheck,
Review comment:
My suggestion is to set doSanityCheck's default value being true, i.e,
we should always validate the instance config unless it is explicitly override
to not doing so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
