kaisun2000 commented on a change in pull request #1119:
URL: https://github.com/apache/helix/pull/1119#discussion_r459656040
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -187,6 +196,10 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
if (zkConnection == null) {
throw new NullPointerException("Zookeeper connection is null!");
}
+
+ String syncUpOnNewSession =
System.getProperty(ZkSystemPropertyKeys.ZK_AUTOSYNC_ENABLED,
ZK_AUTOSYNC_ENABLED_DEFAULT);
+ _syncOnNewSession = Boolean.parseBoolean(syncUpOnNewSession);
Review comment:
_syncOnNewSession is final not static as this allows per zkclient
different _syncOnNewSession behavior. We may later support this from the
ZkClient constructor. Let us just keep it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
