lei-xia commented on a change in pull request #1119:
URL: https://github.com/apache/helix/pull/1119#discussion_r459675880



##########
File path: 
zookeeper-api/src/main/java/org/apache/helix/zookeeper/constant/ZkSystemPropertyKeys.java
##########
@@ -50,4 +50,14 @@
    */
   public static final String ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES =
       "zk.serializer.znrecord.write.size.limit.bytes";
+
+  /**
+   * This property determines the behavior of ZkClient issuing an sync() to 
server upon new session
+   * established.
+   *
+   * <p>
+   *   The default value is "true" (issuing sync)
+   */
+  public static final String ZK_AUTOSYNC_ENABLED =
+      "zk.autosync.enabled";

Review comment:
       should we name it "zk.zkclient.autosync.enabled"?  zk is higher 
namespace, it includes configs not only applies to zkClient, it could be all 
zk-related configs in Helix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to