lei-xia commented on a change in pull request #1119:
URL: https://github.com/apache/helix/pull/1119#discussion_r459678876
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -200,6 +211,10 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
if (zkConnection == null) {
throw new NullPointerException("Zookeeper connection is null!");
}
+
+ String syncUpOnNewSession =
System.getProperty(ZkSystemPropertyKeys.ZK_AUTOSYNC_ENABLED,
ZK_AUTOSYNC_ENABLED_DEFAULT);
+ _syncOnNewSession = Boolean.parseBoolean(syncUpOnNewSession);
Review comment:
Should this config per zkClient or globally in one JVM? If it is
globally, the syncUpOnNewSession should be static and initiated at place it is
defined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
