pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r459659750
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -445,7 +448,8 @@ private Message
createStateTransitionCancellationMessage(HelixManager manager, R
message.setFromState(fromState);
message.setToState(toState);
message.setTgtSessionId(sessionId);
- message.setSrcSessionId(manager.getSessionId());
+ message.setSrcSessionId(managerSessionId);
+ message.setExpectedSessionId(managerSessionId);
Review comment:
The difference I suppose is: say, a message is forwarded/sent from node1
to node2. So srcSessionId = sessionNode1. This message doesn't have to be
written by node1's zkclient, but another zkclient `session-0`. So
expectedSessionId = `session-0`. I'd like to differentiate srcSessionId and
write expectedSessionId.
Let me know I miss anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
