lei-xia commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r459666540
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -757,9 +762,22 @@ private void handleEvent(ClusterEvent event,
BaseControllerDataProvider dataProv
}
event.addAttribute(AttributeName.ControllerDataProvider.name(),
dataProvider);
- logger.info(String.format("START: Invoking %s controller pipeline for
cluster %s event: %s %s",
- manager.getClusterName(), dataProvider.getPipelineName(),
event.getEventType(),
- event.getEventId()));
+ String eventSessionId =
event.getAttribute(AttributeName.EVENT_SESSION.name());
+ if (eventSessionId != null) {
+ String managerSessionId = manager.getSessionId();
+ if (!eventSessionId.equals(managerSessionId)) {
+ logger.warn(
+ "Controller pipeline is not invoked because cluster manager {}
lost leadership for "
Review comment:
This warn message is misleading, it does not necessarily mean the
current controller is not the leader of the cluster. This just means we
discarded event that was generated from an old session.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
