lei-xia commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r459668488
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1360,8 +1390,20 @@ private boolean
updateControllerState(NotificationContext changeContext, PauseSi
String uid = UUID.randomUUID().toString().substring(0, 8);
ClusterEvent event = new ClusterEvent(_clusterName,
ClusterEventType.Resume,
String.format("%s_%s", uid, Pipeline.Type.DEFAULT.name()));
+
+ HelixManager manager = changeContext.getManager();
+ Optional<String> leaderSession = manager.getSessionIdIfLead();
Review comment:
Also using of manager.getSessionIdIfLead here could be confusing. We
used getSessionId in other places, what is the difference? Where we should use
getSessionIdIfLead and where we should use getSessionId?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
