pkuwm commented on a change in pull request #1066:
URL: https://github.com/apache/helix/pull/1066#discussion_r459708644
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -757,9 +762,22 @@ private void handleEvent(ClusterEvent event,
BaseControllerDataProvider dataProv
}
event.addAttribute(AttributeName.ControllerDataProvider.name(),
dataProvider);
- logger.info(String.format("START: Invoking %s controller pipeline for
cluster %s event: %s %s",
- manager.getClusterName(), dataProvider.getPipelineName(),
event.getEventType(),
- event.getEventId()));
+ String eventSessionId =
event.getAttribute(AttributeName.EVENT_SESSION.name());
+ if (eventSessionId != null) {
+ String managerSessionId = manager.getSessionId();
+ if (!eventSessionId.equals(managerSessionId)) {
Review comment:
`String managerSessionId = manager.getSessionId();` is having
`managerSessionId` to be used in if check and log. If we do it in the way you
suggested, either we don't log this manager session, or we need
`manager.getSessionId()` again in log. `getSessionId` also wait for connected.
And if during these two getSessionId, the session id changes, we have different
session ids.
I prefer to log manager session id so this is why I put a variable here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
