zhangmeng916 commented on a change in pull request #1183:
URL: https://github.com/apache/helix/pull/1183#discussion_r463217335
##########
File path: helix-core/src/main/java/org/apache/helix/HelixPropertyFactory.java
##########
@@ -88,8 +88,9 @@ private CloudConfig getCloudConfig(String zkAddress, String
clusterName) {
CloudConfig cloudConfig;
RealmAwareZkClient dedicatedZkClient = null;
try {
- if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED)) {
- // If the multi ZK config is enabled, use multi-realm mode with
DedicatedZkClient
+ if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED) || zkAddress
== null) {
Review comment:
Seems we will need to follow this patten:
`if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED) || zkAddr ==
null)`
in a couple of different places. Is there a better way to represent? The
first one is self explanatory, but the second one does not look
straightforward. The doc for explanation is also in another file.
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerFactory.java
##########
@@ -19,19 +19,18 @@
* under the License.
*/
-/**
- * factory that creates cluster managers
- *
- * for zk-based cluster managers, the getZKXXX(..zkClient) that takes a
zkClient parameter
- * are intended for session expiry test purpose
- */
import org.apache.helix.manager.zk.HelixManagerStateListener;
import org.apache.helix.manager.zk.ZKHelixManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
/**
* Obtain one of a set of Helix cluster managers, organized by the backing
system.
+ * factory that creates cluster managers
+ * *
+ * * for zk-based cluster managers, the getZKXXX(..zkClient) that takes a
zkClient parameter
+ * * are intended for session expiry test purpose
Review comment:
This description is not quite easy to follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
