zhangmeng916 commented on a change in pull request #1183:
URL: https://github.com/apache/helix/pull/1183#discussion_r463239096
##########
File path: helix-core/src/main/java/org/apache/helix/HelixPropertyFactory.java
##########
@@ -88,8 +88,9 @@ private CloudConfig getCloudConfig(String zkAddress, String
clusterName) {
CloudConfig cloudConfig;
RealmAwareZkClient dedicatedZkClient = null;
try {
- if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED)) {
- // If the multi ZK config is enabled, use multi-realm mode with
DedicatedZkClient
+ if (Boolean.getBoolean(SystemPropertyKeys.MULTI_ZK_ENABLED) || zkAddress
== null) {
Review comment:
Could you make it in a function? So for example, if later you have other
conditions, you'll still need to add it in all related places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
