narendly commented on a change in pull request #1183:
URL: https://github.com/apache/helix/pull/1183#discussion_r463222910
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManagerFactory.java
##########
@@ -19,19 +19,18 @@
* under the License.
*/
-/**
- * factory that creates cluster managers
- *
- * for zk-based cluster managers, the getZKXXX(..zkClient) that takes a
zkClient parameter
- * are intended for session expiry test purpose
- */
import org.apache.helix.manager.zk.HelixManagerStateListener;
import org.apache.helix.manager.zk.ZKHelixManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+
/**
* Obtain one of a set of Helix cluster managers, organized by the backing
system.
+ * factory that creates cluster managers
+ * *
+ * * for zk-based cluster managers, the getZKXXX(..zkClient) that takes a
zkClient parameter
+ * * are intended for session expiry test purpose
Review comment:
@zhangmeng916
Objectively, this comment is not very helpful to me - one tip when giving
reviews & comments: either make your comment concrete by clarifying what's not
easy to follow, or suggest an alternative?
With that said, I'm just going to remove the second block since it doesn't
apply here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
