kaisun2000 commented on a change in pull request #1194:
URL: https://github.com/apache/helix/pull/1194#discussion_r463369643
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java
##########
@@ -868,59 +864,38 @@ public void testAsyncWriteOperations() {
* Tests getChildren() when there are an excessive number of children and
connection loss happens,
* the operation should terminate and exit retry loop.
*/
- @Test
+ @Test(timeOut = 30L)
Review comment:
No, run all test from helix. That is what TMC is doing I guess. This is
to simulate that test environment. We don't want that your fix working here but
later it turned out this test still not working TMC. Note the cost over there
is way higher than changing it here.
In fact, I noticed in our test, there are failed test due to Timed out from
time to time. Those failure are likely before the machine may not be able to
schedule the thread to run while the timer is ticking. I don't think it is a
good idea to add a time out here.
By the way, can you re-open this comment thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
