kaisun2000 commented on a change in pull request #1194:
URL: https://github.com/apache/helix/pull/1194#discussion_r463414008
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java
##########
@@ -868,59 +864,38 @@ public void testAsyncWriteOperations() {
* Tests getChildren() when there are an excessive number of children and
connection loss happens,
* the operation should terminate and exit retry loop.
*/
- @Test
+ @Test(timeOut = 30L)
Review comment:
Yes, then remove this timeout. The test has a default timeout 300sec. In
my opinion, relying on 300sec default is much safer. Testing under your own
laptop may not fit a lot other environment.
See this:
[ERROR]
testLostZkConnection(org.apache.helix.integration.TestZkConnectionLost) Time
elapsed: 300.015 s <<< FAILURE!
org.testng.internal.thread.ThreadTimeoutException: Method
org.testng.internal.TestNGMethod.testLostZkConnection() didn't finish within
the time-out 300000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
