pkuwm commented on a change in pull request #1194:
URL: https://github.com/apache/helix/pull/1194#discussion_r463387892
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java
##########
@@ -868,59 +864,38 @@ public void testAsyncWriteOperations() {
* Tests getChildren() when there are an excessive number of children and
connection loss happens,
* the operation should terminate and exit retry loop.
*/
- @Test
+ @Test(timeOut = 30L)
Review comment:
I actually didn't resolve this thread... I intended to keep it open for
discussion.
Running all helix tests is not necessary. This is a separate module. Even
running in the test machine, tests in different modules are independent.
Timeout is good practice. Just an example.
https://github.com/apache/zookeeper/blob/fe940cdd8fb23ba09684cefb73233d570f4a20fa/zookeeper-server/src/test/java/org/apache/zookeeper/server/ZooKeeperServerMainTest.java#L165
How could you ensure 60s would not timeout then? Then how about 10 minutes,
1 hour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
