narendly commented on a change in pull request #1197:
URL: https://github.com/apache/helix/pull/1197#discussion_r464205660
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java
##########
@@ -101,7 +118,7 @@ public HelixDataAccessorWrapper(ZKHelixDataAccessor
dataAccessor) {
}
private Map<String, Boolean> getPartitionsHealth(String instance, ZNRecord
partitionHealthRecord,
- RESTConfig restConfig, Map<String, String> customPayLoads) {
+ RESTConfig restConfig, Map<String, String> customPayLoads, boolean
requireFullRead) {
Review comment:
I suggest we use something like `onlyUseZkAsSource` or something as the
boolean flag, and use the same name all throughout since having `skipZkRead`
and `requireFullRead` here and there could be confusing down the road.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
