narendly commented on a change in pull request #1197:
URL: https://github.com/apache/helix/pull/1197#discussion_r464206347
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -61,19 +61,32 @@
private final HelixDataAccessorWrapper _dataAccessor;
private final ConfigAccessor _configAccessor;
private final CustomRestClient _customRestClient;
+ private boolean _skipZKRead;
public InstanceServiceImpl(HelixDataAccessorWrapper dataAccessor,
ConfigAccessor configAccessor) {
_dataAccessor = dataAccessor;
_configAccessor = configAccessor;
_customRestClient = CustomRestClientFactory.get();
}
+ public InstanceServiceImpl(HelixDataAccessorWrapper dataAccessor,
ConfigAccessor configAccessor, boolean skipZKRead) {
+ this(dataAccessor,configAccessor);
+ this._skipZKRead = skipZKRead;
+ }
+
@VisibleForTesting
InstanceServiceImpl(HelixDataAccessorWrapper dataAccessor, ConfigAccessor
configAccessor,
CustomRestClient customRestClient) {
+ this(dataAccessor, configAccessor, customRestClient, false);
Review comment:
Could we remove this constructor since you added a more comprehensive
one below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
