narendly commented on a change in pull request #1197:
URL: https://github.com/apache/helix/pull/1197#discussion_r464206617



##########
File path: 
helix-rest/src/test/java/org/apache/helix/rest/server/service/TestInstanceService.java
##########
@@ -140,6 +151,70 @@ public void 
testGetInstanceStoppableCheckConnectionRefused() throws IOException
     Assert.assertEquals(actual.getFailedChecks().get(0), expectedFailedCheck);
   }
 
+  @Test
+  public void testCustomPartitionCheckWithSkipZKRead() throws IOException {
+    // Let ZK result is health, but http request is unhealthy.
+    // We expect the check fail if we skipZKRead.
+
+    String testPartition = "PARTITION_0";
+    String slibilingInstance = "instance0.linkedin.com_1236";

Review comment:
       Typo: siblingInstance




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to