narendly commented on a change in pull request #1183:
URL: https://github.com/apache/helix/pull/1183#discussion_r464515535
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -111,7 +111,7 @@
public static final int DEFAULT_MAX_DISCONNECT_THRESHOLD = 600; // Default
to be a large number
private static final int DEFAULT_WAIT_CONNECTED_TIMEOUT = 10 * 1000; //
wait until connected for up to 10 seconds.
- protected final String _zkAddress;
+ protected String _zkAddress;
Review comment:
Now that we've changed the design for HelixManager constructors to
always accept zkAddress, we could bring the `final` keyword back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
