dasahcc commented on a change in pull request #1197:
URL: https://github.com/apache/helix/pull/1197#discussion_r464583525
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java
##########
@@ -101,7 +118,7 @@ public HelixDataAccessorWrapper(ZKHelixDataAccessor
dataAccessor) {
}
private Map<String, Boolean> getPartitionsHealth(String instance, ZNRecord
partitionHealthRecord,
- RESTConfig restConfig, Map<String, String> customPayLoads) {
+ RESTConfig restConfig, Map<String, String> customPayLoads, boolean
requireFullRead) {
Review comment:
I understand your concern. But it will be confusing to use one flag
because they are completely in different purpose:
1. Skip the zk access for reading partition health.
2. Because of the contract we made for customized API, if no entry as body
for "PARTITION", they will return all the partition health status. If they have
it but partition list is empty, no result will be return. Here' when we only do
partition health retrieving, we dont know what are the partitions on the
instance. Also this function I would say is a separate function and logically
not connected with "skipZKRead"
I can add some comments in the function and rename the function. But I do
not think make this name to be "onlyUseZkAsSource" is a good choice. There are
no logic related to ZK for this private function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
