jiajunwang commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r476862904
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -222,22 +226,16 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
_asyncCallRetryThread.start();
LOG.debug("ZkClient created with _uid {}, _asyncCallRetryThread id {}",
_uid, _asyncCallRetryThread.getId());
- connect(connectionTimeout, this);
-
- // initiate monitor
- try {
- if (monitorKey != null && !monitorKey.isEmpty() && monitorType != null
&& !monitorType
- .isEmpty()) {
- _monitor =
- new ZkClientMonitor(monitorType, monitorKey, monitorInstanceName,
monitorRootPathOnly,
- _eventThread);
- _monitor.register();
- } else {
- LOG.info("ZkClient monitor key or type is not provided. Skip
monitoring.");
- }
- } catch (JMException e) {
- LOG.error("Error in creating ZkClientMonitor", e);
+ if (monitorKey != null && !monitorKey.isEmpty() && monitorType != null &&
!monitorType
+ .isEmpty()) {
+ _monitor =
+ new ZkClientMonitor(monitorType, monitorKey, monitorInstanceName,
monitorRootPathOnly,
+ _eventThread);
Review comment:
Synced with Kai offline, the 2nd point is fine since the register will
be postpone to the connect. Given this, I would prefer making the registration
logic closer to the monitor construct logic.
So shall we pass the ZkClientMonitor into connect() to explicitly update it
in the call. Then register the monitor after the connect(), but still in the
constructor.
pseudo code:
_monitor = new ZkClientMonitor();
// Comment that we need to update the _monitor in the event lock to avoid
missing any records about event thread.
connect(connectTimeout, this, _monitor);
_monitor.register()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
