pkuwm commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r477028039
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java
##########
@@ -143,7 +143,11 @@ protected ZkServer startZkServer(final String zkAddress) {
int port = Integer.parseInt(zkAddress.substring(zkAddress.lastIndexOf(':')
+ 1));
ZkServer zkServer = new ZkServer(dataDir, logDir, defaultNameSpace, port);
System.out.println("Starting ZK server at " + zkAddress);
- zkServer.start();
+ try {
+ zkServer.start();
+ } catch (Exception e) {
Review comment:
What's the reason to catch exception and print? I guess you want to have
the stacktrace for debugging. But please be noted that if exception is thrown,
this change will return a zkServer that's not started. I don't think this is
what you expected, is it?
I guest keeping it to throw exception so the test would not proceed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
