kaisun2000 commented on a change in pull request #1295:
URL: https://github.com/apache/helix/pull/1295#discussion_r477480668
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java
##########
@@ -143,7 +143,11 @@ protected ZkServer startZkServer(final String zkAddress) {
int port = Integer.parseInt(zkAddress.substring(zkAddress.lastIndexOf(':')
+ 1));
ZkServer zkServer = new ZkServer(dataDir, logDir, defaultNameSpace, port);
System.out.println("Starting ZK server at " + zkAddress);
- zkServer.start();
+ try {
+ zkServer.start();
+ } catch (Exception e) {
Review comment:
You are right. Let me re-throw the exception to prevent the test from
proceeding.
Without printing it out here, the problem is that Intellij will not print
out the exception here. Thus, it seems to be a mystery as why all the test is
skipped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
