kaisun2000 commented on a change in pull request #1401:
URL: https://github.com/apache/helix/pull/1401#discussion_r493967728
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAutoRebalance.java
##########
@@ -229,6 +236,16 @@ static boolean verifyBalanceExternalView(ZNRecord
externalView, int partitionCou
return partitionCount == totalCount;
}
+ private void setupAutoRebalancer() {
+ HelixAdmin admin = _gSetupTool.getClusterManagementTool();
Review comment:
This actually relies on the fact that
```
_gSetupTool.addResourceToCluster(CLUSTER_NAME, "MyDB2", _PARTITIONS,
"MasterSlave",
RebalanceMode.FULL_AUTO + "");
```
would add idea state using DelayedAutoRebalancer + AutoRebalance strategy
here, we change the idea state to use autoRebalancer, thus eventually we end
up with autoRebalancer + autoRebalance strategy.
The thing is that if later people change the
gSetupTool.addResourceToCluster() similar to testhelper to have
DelayedAutoRebalancer + crushEd, this test won't work.
Shall we add a comment that we depends on _gSetupTool.addResourceToCluster
to use default AutoRebalanceStrategy, or just note here we need autoRebalancer
+ autoRebalance strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
