jiajunwang commented on a change in pull request #1401:
URL: https://github.com/apache/helix/pull/1401#discussion_r493974320
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAutoRebalancePartitionLimit.java
##########
@@ -204,10 +215,14 @@ public boolean verify() {
cache.getStateModelDef(cache.getIdealState(_resourceName).getStateModelDefRef())
.getStatesPriorityList().get(0);
int replicas =
Integer.parseInt(cache.getIdealState(_resourceName).getReplicas());
- return verifyBalanceExternalView(
-
accessor.getProperty(keyBuilder.externalView(_resourceName)).getRecord(),
- numberOfPartitions, masterValue, replicas,
cache.getLiveInstances().size(),
- cache.getIdealState(_resourceName).getMaxPartitionsPerInstance());
+ try {
+ return verifyBalanceExternalView(
+
accessor.getProperty(keyBuilder.externalView(_resourceName)).getRecord(),
+ numberOfPartitions, masterValue, replicas,
cache.getLiveInstances().size(),
+ cache.getIdealState(_resourceName).getMaxPartitionsPerInstance());
+ } catch (Exception e) {
+ return false;
Review comment:
Let me add a debug log here.
1. It is expected. Since the EV might not be created when the verify starts.
So if we output an error message, it only pollutes the log with no good reason.
2. It will be retried in the loop. It would be too verbose if we output on
every checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
